Run queries twice to test for idempotence #159
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Adds tests for the idempotence of
query()
to address https://app.shortcut.com/tiledb-inc/story/32367/add-tests-for-query-idempotence. There is not much of a speed difference from repeating.query()
twice, though I'm very open to other suggestions on how to test this. Alternatives include:apis/python/test/test_index.py
, i.e.test_flat_index_idempotence
andtest_ivf_flat_index_idempotence
apis/python/test/test_ingestion.py
, i.e.test_flat_index_idempotence
andtest_ivf_flat_index_idempotence
apis/python/test/test_query.py
, i.e.test_flat_index_idempotence
andtest_ivf_flat_index_idempotence
apis/python/test/test_ingestion.py
and run the loop on thequery()
calls in thereTesting
Before:
After: