Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix corner cases for ingestion #156

Merged
merged 3 commits into from
Nov 29, 2023
Merged

Fix corner cases for ingestion #156

merged 3 commits into from
Nov 29, 2023

Conversation

NikolaosPapailiou
Copy link
Collaborator

@NikolaosPapailiou NikolaosPapailiou commented Nov 27, 2023 •
edited
Loading

This PR fixes the following bugs:

  • In the case of multiple batches per ingestion worker, the task_ids were not generated correctly and the udfs failed to write to the correct partial arrays
  • After ingestion, the temp_data array was deleted but not removed leading to vector index groups that failed to register in cloud.

@NikolaosPapailiou NikolaosPapailiou marked this pull request as ready for review November 28, 2023 13:56
@NikolaosPapailiou NikolaosPapailiou merged commit 2ad1ae4 into main Nov 29, 2023
4 checks passed
@NikolaosPapailiou NikolaosPapailiou deleted the npapa/fix-ingestion branch November 29, 2023 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ihnorton ihnorton ihnorton approved these changes

@lums658 lums658 Awaiting requested review from lums658

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NikolaosPapailiou @ihnorton