Skip to content

Commit

Permalink
cleanup
Browse files Browse the repository at this point in the history
  • Loading branch information
jparismorgan committed Oct 17, 2024
1 parent d5f676e commit 9b3e42d
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 12 deletions.
16 changes: 8 additions & 8 deletions apis/python/src/tiledb/vector_search/ingestion.py
Original file line number Diff line number Diff line change
Expand Up @@ -1916,7 +1916,7 @@ def ingest_vectors_udf(
start=part,
end=part_end,
partition_start=part_id * (partitions + 1),
partial_write_array_dir=PARTIAL_WRITE_ARRAY_DIR
partial_write_array_dir=PARTIAL_WRITE_ARRAY_DIR,
)
else:
ivf_index_tdb(
Expand Down Expand Up @@ -1974,7 +1974,7 @@ def ingest_vectors_udf(
start=part,
end=part_end,
partition_start=part_id * (partitions + 1),
partial_write_array_dir=PARTIAL_WRITE_ARRAY_DIR
partial_write_array_dir=PARTIAL_WRITE_ARRAY_DIR,
)
else:
ivf_index(
Expand Down Expand Up @@ -2065,7 +2065,7 @@ def ingest_additions_udf(
start=write_offset,
end=0,
partition_start=partition_start,
partial_write_array_dir=PARTIAL_WRITE_ARRAY_DIR
partial_write_array_dir=PARTIAL_WRITE_ARRAY_DIR,
)
else:
ivf_index(
Expand Down Expand Up @@ -2158,12 +2158,12 @@ def ivf_pq_consolidate_partition_udf(
to_temporal_policy(index_timestamp),
)
index.consolidate_partitions(
partitions=partitions,
work_items=work_items,
partition_id_start=partition_id_start,
partition_id_end=partition_id_end,
partitions=partitions,
work_items=work_items,
partition_id_start=partition_id_start,
partition_id_end=partition_id_end,
batch=batch,
partial_write_array_dir=PARTIAL_WRITE_ARRAY_DIR
partial_write_array_dir=PARTIAL_WRITE_ARRAY_DIR,
)

def consolidate_partition_udf(
Expand Down
6 changes: 2 additions & 4 deletions src/include/index/ivf_pq_group.h
Original file line number Diff line number Diff line change
Expand Up @@ -338,24 +338,22 @@ class ivf_pq_group : public base_index_group<index_type> {
tiledb_helpers::add_to_group(
write_group, flat_ivf_centroids_uri(), flat_ivf_centroids_array_name());

// create_temp_data_group();

metadata_.store_metadata(write_group);
}

void create_temp_data_group(const std::string& partial_write_array_dir) {
auto write_group = tiledb::Group(
cached_ctx_, group_uri_, TILEDB_WRITE, cached_ctx_.config());

// Then create the new temp data group.
// Create the new temp data group.
tiledb::Group::create(
cached_ctx_, this->temp_data_uri(partial_write_array_dir));
tiledb_helpers::add_to_group(
write_group,
this->temp_data_uri(partial_write_array_dir),
partial_write_array_dir);

// Finally create the array's in the temp data group that we will need
// Then create the array's in the temp data group that we will need
// during ingestion.
auto temp_group = tiledb::Group(
cached_ctx_,
Expand Down

0 comments on commit 9b3e42d

Please sign in to comment.