Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable possibility to end name with "/" for scoped packages #175

Closed
wants to merge 1 commit into from

Conversation

dohomi
Copy link

@dohomi dohomi commented Apr 22, 2023

This would be very helpful to still upgrade scoped packages like @scoped-name/ which currently fails:

manypkg upgrade @scoped-name/

@changeset-bot
Copy link

changeset-bot bot commented Apr 22, 2023

⚠️ No Changeset found

Latest commit: 5db57d7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dohomi
Copy link
Author

dohomi commented Apr 22, 2023

Example:

manypkg upgrade @tamagui/

currently does not work.

manypkg upgrade @tamagui

works but it also upgrades @tamagui-extras which is not intended.

@emmatown
Copy link
Member

emmatown commented May 14, 2023

Could you update this PR so that writing @scope in the CLI looks for packages starting with @scope/ rather than @scope? That was the original intent.

@Andarist
Copy link
Collaborator

Closed by #206

@Andarist Andarist closed this Apr 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants