Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor popover improvements #779

Merged
merged 5 commits into from
Nov 24, 2023
Merged

Editor popover improvements #779

merged 5 commits into from
Nov 24, 2023

Conversation

jossmac
Copy link
Member

@jossmac jossmac commented Nov 24, 2023

@keystar/ui

  • Support "boundary" + "portal" props on EditorPopover component.
  • Simulate clipping for portal'd popovers.

@keystatic/core

  • Markdoc editor boundary respected by popovers.
  • Markdoc editor popovers tethered to reference regardless of type (node/range/virtual) + better perf.

@jossmac jossmac requested a review from emmatown as a code owner November 24, 2023 03:17
Copy link

changeset-bot bot commented Nov 24, 2023

🦋 Changeset detected

Latest commit: f2ccc1c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@keystatic/core Patch
@keystar/ui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Nov 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
keystatic-site ✅ Ready (Inspect) Visit Preview Nov 24, 2023 3:17am
3 Ignored Deployments
Name Status Preview Updated (UTC)
keystar-ui ⬜️ Ignored (Inspect) Nov 24, 2023 3:17am
keystatic ⬜️ Ignored (Inspect) Nov 24, 2023 3:17am
keystatic-next-blocks-builder ⬜️ Ignored (Inspect) Nov 24, 2023 3:17am

@jossmac jossmac merged commit 0ca7f47 into main Nov 24, 2023
@jossmac jossmac deleted the editor-popover-improvements branch November 24, 2023 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants