Add Ast class
#29
Merged
Add Ast class
#29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheVaultdweller13
approved these changes
Jan 8, 2025
| @@ -21,7 +32,7 @@ def __init__( | |||
| def parse(self, program): | |||
| program = self.preprocessor.process(program) | |||
| tree = self.grammar.parse(program) | |||
| return self.visitor.visit(tree) | |||
| return Ast(self.visitor.visit(tree)) | |||
There was a problem hiding this comment.
I love the idea of adding as much typing and object orientation as possible. I would add program: str to the method's input so that it is fully typed, both in its input and output.
|
Approve with suggestions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We refactor the AST produced by the parser to a new class that's compatible with the existing code but will allow us to extend the AST with new behaviours in the future without compromising the existing interface. The original tuple-based tree can still be accessed via
Ast#treemethod.This class also provides extra name-based type safety under a convenient name.