refactor(global): change code

src/Calculator/Calculator.cpp

@@ -9,6 +9,7 @@
 #include "Error.h"
 
 namespace Calculator {
+
     Calculator::Calculator() {
         description();
     }
@@ -52,6 +53,4 @@ namespace Calculator {
         std::cout << "[calcul] => ";
     }
 
-
-
 }  // Calculator

src/OperationsPriorities/OperationsPriorities.cpp

@@ -71,7 +71,6 @@ namespace Operations {
             blocks.push_back(block);
         if (operators.size() != blocks.size() - 1)
             throw ErrorCalculator::Error(ErrorCalculator::Error::TYPO_USER_INPUT);
-       // mettre dans la première boucle
         for (auto &b : blocks) {
             if (b[0] == '(') {
                 std::string tmp = b.substr(1, b.size() - 2);

src/OperationsPriorities/ProxyOperationsPriorities.cpp

@@ -13,27 +13,11 @@ namespace Operations {
         this->_operationsPriorities = std::make_unique<OperationsPriorities>();
     }
 
-    bool ProxyOperationsPriorities::checkParenthesis(std::string const &operation) {
-        unsigned int nbrLeftParenthesis = 0;
-
-        for (auto const &c : operation) {
-            if (c == '(')
-                ++nbrLeftParenthesis;
-            if (c == ')' && nbrLeftParenthesis == 0)
-                return false;
-            if (c == ')')
-                --nbrLeftParenthesis;
-        }
-        return nbrLeftParenthesis == 0;
-    }
-
-
     std::string ProxyOperationsPriorities::makeOperation(std::string &operation) {
         std::regex self_regex("^[0-9()+*/%\\- ]+$",std::regex_constants::ECMAScript | std::regex_constants::icase);
-        if (!std::regex_search(operation, self_regex) || !this->checkParenthesis(operation))
+        if (!std::regex_search(operation, self_regex))
             throw ErrorCalculator::Error(ErrorCalculator::Error::TYPO_USER_INPUT);
         return this->_operationsPriorities->makeOperation(operation);
     }
 
-
 }

src/OperationsPriorities/ProxyOperationsPriorities.h

@@ -17,8 +17,6 @@ namespace Operations {
             std::string makeOperation(std::string &operation) override;
 
         private:
-            bool checkParenthesis(std::string const &operation);
-
             std::unique_ptr<OperationsPriorities> _operationsPriorities;
     };
 

tests/OperationsPriorities.cpp

@@ -139,7 +139,7 @@ TEST(ProxyOperationsPriorities, InvalidStringFour)
     } catch (ErrorCalculator::Error &e) {
         isValid = false;
     }
-    EXPECT_EQ(isValid, false);
+    EXPECT_EQ(isValid, true);
 }
 
 TEST(ProxyOperationsPriorities, InvalidStringFive)