removed user from _feed

Author: TheHCJ

lib/home/_feed.dart

@@ -15,7 +15,7 @@ class FeedScreen extends StatefulWidget {
   final String id;
   final String name;
 
-  const FeedScreen({Key? key, required this.scrollController, required this.id, required this.name}) : super(key: key);
+  const FeedScreen({super.key, required this.scrollController, required this.id, required this.name});
 
   @override
   State<FeedScreen> createState() => _FeedScreenState();
@@ -30,7 +30,6 @@ class _FeedScreenState extends State<FeedScreen>
 
   late TabController _tabController;
   int _tab = 0;
-  dynamic _tabValue = L10n.current.following;
   Duration animationDuration = Duration.zero;
 
   @override
@@ -53,10 +52,6 @@ class _FeedScreenState extends State<FeedScreen>
     super.build(context);
     final bool _disableAnimations = PrefService.of(context).get(optionDisableAnimations) == true;
 
-    user.idStr = "1";
-    user.possiblySensitive = false;
-    user.screenName = "ForYou";
-
     return Provider<GroupModel>(create: (context) {
       var model = GroupModel(widget.id);
       model.loadGroup();
@@ -84,7 +79,6 @@ class _FeedScreenState extends State<FeedScreen>
                           } else if (value == L10n.current.following) {
                             _tab = 0;
                           }
-                          _tabValue = value;
                         }),
                     dropdownMenuEntries: [
                       DropdownMenuEntry(value: L10n.current.following, label: L10n.current.following),
@@ -131,8 +125,7 @@ class _FeedScreenState extends State<FeedScreen>
             SubscriptionGroupScreenContent(
               id: widget.id,
             ),
-            ForYouTweets(
-                user: user, type: 'profile', includeReplies: false, pinnedTweets: [], pref: PrefService.of(context)),
+            ForYouTweets(type: 'profile', includeReplies: false, pinnedTweets: [], pref: PrefService.of(context)),
           ][_tab]);
     });
   }

lib/home/_forYou.dart

@@ -10,20 +10,16 @@ import 'package:pref/pref.dart';
 import 'package:provider/provider.dart';
 import '../constants.dart';
 
+final UserWithExtra user = UserWithExtra();
+
 class ForYouTweets extends StatefulWidget {
-  final UserWithExtra user;
   final String type;
   final bool includeReplies;
   final List<String> pinnedTweets;
   final BasePrefService pref;
 
   const ForYouTweets(
-      {Key? key,
-      required this.user,
-      required this.type,
-      required this.includeReplies,
-      required this.pinnedTweets,
-      required this.pref})
+      {Key? key, required this.type, required this.includeReplies, required this.pinnedTweets, required this.pref})
       : super(key: key);
 
   @override
@@ -40,6 +36,9 @@ class _ForYouTweetsState extends State<ForYouTweets> with AutomaticKeepAliveClie
   @override
   void initState() {
     super.initState();
+    user.idStr = "1";
+    user.possiblySensitive = false;
+    user.screenName = "ForYou";
     _pagingController = PagingController(firstPageKey: null);
     _pagingController.addPageRequestListener((cursor) {
       _loadTweets(cursor);
@@ -63,7 +62,7 @@ class _ForYouTweetsState extends State<ForYouTweets> with AutomaticKeepAliveClie
   Future _loadTweets(String? cursor) async {
     try {
       var result = await Twitter.getTimelineTweets(
-        widget.user.idStr!,
+        user.idStr!,
         widget.type,
         widget.pinnedTweets,
         cursor: cursor,
@@ -99,7 +98,7 @@ class _ForYouTweetsState extends State<ForYouTweets> with AutomaticKeepAliveClie
         ],
         builder: (context, child) {
           return Consumer<TweetContextState>(builder: (context, model, child) {
-            if (model.hideSensitive && (widget.user.possiblySensitive ?? false)) {
+            if (model.hideSensitive && (user.possiblySensitive ?? false)) {
               return EmojiErrorWidget(
                 emoji: '🍆🙈🍆',
                 message: L10n.current.possibly_sensitive,
@@ -118,10 +117,7 @@ class _ForYouTweetsState extends State<ForYouTweets> with AutomaticKeepAliveClie
                 builderDelegate: PagedChildBuilderDelegate(
                   itemBuilder: (context, chain, index) {
                     return TweetConversation(
-                        id: chain.id,
-                        tweets: chain.tweets,
-                        username: widget.user.screenName!,
-                        isPinned: chain.isPinned);
+                        id: chain.id, tweets: chain.tweets, username: user.screenName!, isPinned: chain.isPinned);
                   },
                   firstPageErrorIndicatorBuilder: (context) => FullPageErrorWidget(
                     error: _pagingController.error[0],