ORM:Avoid unnecessary copies when returning search results (drogonframework#2237)

an-tao · web-flow · commit 152a69f1e96c · 2025-01-02T22:44:09.000+08:00
diff --git a/orm_lib/inc/drogon/orm/Mapper.h b/orm_lib/inc/drogon/orm/Mapper.h
@@ -1053,9 +1053,9 @@ inline void Mapper<T>::findBy(const Criteria &criteria,
         std::vector<T> ret;
         for (auto const &row : r)
         {
-            ret.push_back(T(row));
+            ret.emplace_back(row);
         }
-        rcb(ret);
+        rcb(std::move(ret));
     };
     binder >> ecb;
 }

Original file line number	Diff line number	Diff line change
`@@ -1053,9 +1053,9 @@ inline void Mapper<T>::findBy(const Criteria &criteria,`
`1053`	`1053`	`std::vector<T> ret;`
`1054`	`1054`	`for (auto const &row : r)`
`1055`	`1055`	`{`
`1056`		`- ret.push_back(T(row));`
	`1056`	`+ ret.emplace_back(row);`
`1057`	`1057`	`}`
`1058`		`- rcb(ret);`
	`1058`	`+ rcb(std::move(ret));`
`1059`	`1059`	`};`
`1060`	`1060`	`binder >> ecb;`
`1061`	`1061`	`}`