From ecd91009caa1d57b7cfd41ccc2aa2e2103ceadc9 Mon Sep 17 00:00:00 2001 From: Stefano Novelli Date: Fri, 1 Mar 2024 17:05:08 +0100 Subject: [PATCH 1/3] Remove unnecessary method chaining for readability in ReadabilityServiceProvider. --- src/ReadabilityServiceProvider.php | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/src/ReadabilityServiceProvider.php b/src/ReadabilityServiceProvider.php index 6655eda..c2fb9ed 100644 --- a/src/ReadabilityServiceProvider.php +++ b/src/ReadabilityServiceProvider.php @@ -4,7 +4,6 @@ use Spatie\LaravelPackageTools\Package; use Spatie\LaravelPackageTools\PackageServiceProvider; -use The3LabsTeam\Readability\Commands\ReadabilityCommand; class ReadabilityServiceProvider extends PackageServiceProvider { @@ -16,10 +15,10 @@ public function configurePackage(Package $package): void * More info: https://github.com/spatie/laravel-package-tools */ $package - ->name('laravel-readability') - ->hasConfigFile() - ->hasViews() - ->hasMigration('create_laravel-readability_table') - ->hasCommand(ReadabilityCommand::class); + ->name('laravel-readability'); +// ->hasConfigFile() +// ->hasViews() +// ->hasMigration('create_laravel-readability_table') +// ->hasCommand(ReadabilityCommand::class); } } From 5f0be1b4679a043855e9a20bb85178b79bce474b Mon Sep 17 00:00:00 2001 From: Stefano Novelli Date: Fri, 1 Mar 2024 17:06:10 +0100 Subject: [PATCH 2/3] Remove unecessary scaffolding --- database/factories/ModelFactory.php | 19 ------------------- .../create_readability_table.php.stub | 19 ------------------- resources/views/.gitkeep | 0 src/Commands/ReadabilityCommand.php | 19 ------------------- src/ReadabilityServiceProvider.php | 4 ---- 5 files changed, 61 deletions(-) delete mode 100644 database/factories/ModelFactory.php delete mode 100644 database/migrations/create_readability_table.php.stub delete mode 100644 resources/views/.gitkeep delete mode 100644 src/Commands/ReadabilityCommand.php diff --git a/database/factories/ModelFactory.php b/database/factories/ModelFactory.php deleted file mode 100644 index 761107c..0000000 --- a/database/factories/ModelFactory.php +++ /dev/null @@ -1,19 +0,0 @@ -id(); - - // add fields - - $table->timestamps(); - }); - } -}; diff --git a/resources/views/.gitkeep b/resources/views/.gitkeep deleted file mode 100644 index e69de29..0000000 diff --git a/src/Commands/ReadabilityCommand.php b/src/Commands/ReadabilityCommand.php deleted file mode 100644 index 4e8e744..0000000 --- a/src/Commands/ReadabilityCommand.php +++ /dev/null @@ -1,19 +0,0 @@ -comment('All done'); - - return self::SUCCESS; - } -} diff --git a/src/ReadabilityServiceProvider.php b/src/ReadabilityServiceProvider.php index c2fb9ed..7d12120 100644 --- a/src/ReadabilityServiceProvider.php +++ b/src/ReadabilityServiceProvider.php @@ -16,9 +16,5 @@ public function configurePackage(Package $package): void */ $package ->name('laravel-readability'); -// ->hasConfigFile() -// ->hasViews() -// ->hasMigration('create_laravel-readability_table') -// ->hasCommand(ReadabilityCommand::class); } } From 8981b54e2a8980a7063f54317ae9b5aa5038df70 Mon Sep 17 00:00:00 2001 From: Stefano Novelli Date: Fri, 1 Mar 2024 17:10:08 +0100 Subject: [PATCH 3/3] Remove "database" path from phpstan.neon.dist configuration. --- phpstan.neon.dist | 1 - 1 file changed, 1 deletion(-) diff --git a/phpstan.neon.dist b/phpstan.neon.dist index 489fa4e..768d487 100644 --- a/phpstan.neon.dist +++ b/phpstan.neon.dist @@ -6,7 +6,6 @@ parameters: paths: - src - config - - database tmpDir: build/phpstan checkOctaneCompatibility: true checkModelProperties: true