Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleting items on death if "Prevent_Item_Drop: True" #42

Open
keenerb opened this issue Mar 19, 2015 · 5 comments
Open

Deleting items on death if "Prevent_Item_Drop: True" #42

keenerb opened this issue Mar 19, 2015 · 5 comments

Comments

@keenerb
Copy link

keenerb commented Mar 19, 2015

Cauldron 1.7.10, Soulbound v1.1.9.

This may just be my misunderstanding, but I believe it's a bug.

I've given the default group soulbound.items.keep_on_death' permission. Initially everything worked fine, people would die and keep their soulbound items. But, a few people managed to toss a soulbound whatever into lava or in the ocean and what have you, so I set 'Prevent_Item_Drop: true'

However, now when someone dies they simply lose their soulbound items. All their soulbound items.

I don't know why that happens, but that's what I am seeing.

https://www.youtube.com/watch?v=KpTrxNL2Kb4&feature=youtu.be

Sorry for the horrible cropping job, but you can see where I bind a sign, try to drop it, and then it's lost when I /kill.


#
#  Soulbound configuration
#  Last updated on 1.1.9-b71
#
#####

#
#  Settings for Soulbound in general
###
General:
    # Allow Soulbound to report on basic anonymous usage
    Stats_Tracking: false

    # Allow Soulbound to check if a new version is available
    Update_Check: false
    Prefer_Beta: false

    # Should Soulbound print out debug messages?
    Verbose_Logging: true

    # Should Soulbound over-write configs to update, or make new ones ending in .new?
    Config_Update_Overwrite: true

Soulbound:
    Feedback_Messages_Enabled: true
    Prevent_Item_Drop: true
    Delete_On_Drop: false
    Allow_Item_Storing: true
    Infinite_Durability: false
    Blocked_Commands:
        /blockedcommand
    Commands_Bind_When_Used:
        /enchant

Dependency_Plugins:
    DiabloDrops:
        BindOnPickup: Legendary, Rare, Unidentified
        BindOnUse: Magical
        BindOnEquip: Set
    EpicBossRecoded:
        BindOnPickup: true
        BindOnUse: false
        BindOnEquip: false
    LoreLocks:
        Bind_Keys: true
    MythicDrops:
        BindOnPickup: common, uncommon, rare
        BindOnUse: terric, netheric
        BindOnEquip: endric
@TfT-02
Copy link
Owner

TfT-02 commented Mar 20, 2015

Does this also happen when you die of a 'natural cause' ? So not from using the kill command, but a death causes by for example lava.

@keenerb
Copy link
Author

keenerb commented Mar 22, 2015

I'll check. Pretty sure it does, because my players have been reporting that their items are lost when they die.

@keenerb
Copy link
Author

keenerb commented Mar 23, 2015

yeah it's happening from creeper explosions, /kill, and jumping in lava.

Again, just to re-iterate, this is a modded server, so maybe that has something to do with it?

@TheCavemanOfficial
Copy link

Im having this same issue, except i keep all my items, ive added the permission node to keep items on death but it still forces them to drop the item....

@MadamQuesting
Copy link

[11:35:35] [Server thread/ERROR]: Could not pass event PlayerCommandPreprocessEvent to Soulbound v1.1.7-b16
org.bukkit.event.EventException
at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:305) ~[spigot.jar:git-Spigot-c3c767f-33d5de3]
at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:62) ~[spigot.jar:git-Spigot-c3c767f-33d5de3]
at org.bukkit.plugin.SimplePluginManager.fireEvent(SimplePluginManager.java:502) [spigot.jar:git-Spigot-c3c767f-33d5de3]
at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:487) [spigot.jar:git-Spigot-c3c767f-33d5de3]
at net.minecraft.server.v1_8_R1.PlayerConnection.handleCommand(PlayerConnection.java:1107) [spigot.jar:git-Spigot-c3c767f-33d5de3]
at net.minecraft.server.v1_8_R1.PlayerConnection.a(PlayerConnection.java:950) [spigot.jar:git-Spigot-c3c767f-33d5de3]
at net.minecraft.server.v1_8_R1.PacketPlayInChat.a(PacketPlayInChat.java:26) [spigot.jar:git-Spigot-c3c767f-33d5de3]
at net.minecraft.server.v1_8_R1.PacketPlayInChat.a(PacketPlayInChat.java:53) [spigot.jar:git-Spigot-c3c767f-33d5de3]
at net.minecraft.server.v1_8_R1.PacketHandleTask.run(SourceFile:13) [spigot.jar:git-Spigot-c3c767f-33d5de3]
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471) [?:1.7.0_51]
at java.util.concurrent.FutureTask.run(FutureTask.java:262) [?:1.7.0_51]
at net.minecraft.server.v1_8_R1.MinecraftServer.z(MinecraftServer.java:696) [spigot.jar:git-Spigot-c3c767f-33d5de3]
at net.minecraft.server.v1_8_R1.DedicatedServer.z(DedicatedServer.java:316) [spigot.jar:git-Spigot-c3c767f-33d5de3]
at net.minecraft.server.v1_8_R1.MinecraftServer.y(MinecraftServer.java:634) [spigot.jar:git-Spigot-c3c767f-33d5de3]
at net.minecraft.server.v1_8_R1.MinecraftServer.run(MinecraftServer.java:537) [spigot.jar:git-Spigot-c3c767f-33d5de3]
at java.lang.Thread.run(Thread.java:744) [?:1.7.0_51]
Caused by: java.lang.NullPointerException
at com.me.tft_02.soulbound.util.ItemUtils.soulbindItem(ItemUtils.java:46) ~[?:?]
at com.me.tft_02.soulbound.listeners.PlayerListener.onPlayerCommandMonitor(PlayerListener.java:232) ~[?:?]
at sun.reflect.GeneratedMethodAccessor301.invoke(Unknown Source) ~[?:?]
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.7.0_51]
at java.lang.reflect.Method.invoke(Method.java:606) ~[?:1.7.0_51]
at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:301) ~[spigot.jar:git-Spigot-c3c767f-33d5de3]
... 15 more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants