Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

console warning of zustand #230

Closed
msyesyan opened this issue Feb 11, 2023 · 2 comments
Closed

console warning of zustand #230

msyesyan opened this issue Feb 11, 2023 · 2 comments
Labels
duplicate This issue or pull request already exists

Comments

@msyesyan
Copy link

Screen Shot 2023-02-11 at 09 29 14

Screen Shot 2023-02-11 at 09 38 03

The json-viewer is amazing however it will console a lot of warning message because of some deprecated usage of zustand. these console warning message give me some trouble, do you have a plan to check and replace these deprecated methods and release a new npm version? thanks
@pionxzh
Copy link
Collaborator

pionxzh commented Feb 11, 2023

Yes. We are considering moving to React context or another state-management solution. Or maybe just migrate the deprecated part 😄

@pionxzh
Copy link
Collaborator

pionxzh commented Feb 11, 2023

Duplicate of #144

@pionxzh pionxzh marked this as a duplicate of #144 Feb 11, 2023
@pionxzh pionxzh added the duplicate This issue or pull request already exists label Feb 11, 2023
@pionxzh pionxzh closed this as not planned Won't fix, can't repro, duplicate, stale Feb 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
duplicate This issue or pull request already exists
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@msyesyan @pionxzh