Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zookeeper Provider for Tenants #661

Merged
merged 4 commits into from
Jan 15, 2025
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions asab/web/tenant/providers/__init__.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
from .static import StaticTenantProvider
from .web import WebTenantProvider
from .zookeeper import ZookeeperTenantProvider

__all__ = [
"StaticTenantProvider",
"WebTenantProvider",
"ZookeeperTenantProvider"
]
70 changes: 70 additions & 0 deletions asab/web/tenant/providers/zookeeper.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,70 @@
import typing
import logging

from .abc import TenantProviderABC
from ....zookeeper import ZooKeeperContainer


L = logging.getLogger(__name__)


class ZookeeperTenantProvider(TenantProviderABC):
def __init__(self, app, tenant_service, config):
super().__init__(app, tenant_service, config)
self.Tenants: typing.Set[str] = set()

# Initialize ZooKeeper Client
self.ZooKeeperService = self.App.get_service("asab.ZooKeeperService")
self.ZKPath = self.Config.get("zk_path")
self.ZookeeperContainer = ZooKeeperContainer(
self.ZooKeeperService,
config_section_name="zookeeper",
z_path=self.ZKPath
)
self.ZookeeperClient = self.ZookeeperContainer.ZooKeeper


async def get_tenants(self) -> typing.Set[str]:
return self.Tenants


async def is_tenant_known(self, tenant: str) -> bool:
return tenant in self.Tenants


async def update(self):
try:
zk_node_exists = await self.ZookeeperClient.exists(self.ZKPath)

if zk_node_exists:
external_tenants = await self.ZookeeperClient.get_children(self.ZKPath)
self._set_ready(True) # Provider was checked => True
language-shprt marked this conversation as resolved.
Show resolved Hide resolved

elif zk_node_exists is None:
L.warning(
language-shprt marked this conversation as resolved.
Show resolved Hide resolved
"Failed to load tenants: zk node doesn't exist",
struct_data={"path": self.ZKPath}
)
self._set_ready(True) # Provider was checked (no data in ZK) => True
return

except Exception as e:
self._set_ready(False) # Failed to check the provider
L.exception(
"Failed to load tenants",
struct_data={
"class": e.__class__.__name__.__str__(),
"reason": str(e),
"path": self.ZKPath
}
)
return

new_tenants = set(external_tenants)
if self.Tenants != new_tenants:
L.debug("Tenants from Zookeeper updated", struct_data={"path": self.ZKPath})
self.Tenants = new_tenants
self.App.PubSub.publish("Tenants.change!")

if not self._IsReady:
self._set_ready(True)
4 changes: 4 additions & 0 deletions asab/web/tenant/service.py
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,10 @@ def _prepare_providers(self):
from .providers import WebTenantProvider
self.Providers.append(WebTenantProvider(self.App, self, Config["tenants"]))

if Config.get("zookeeper", "servers", fallback=None):
language-shprt marked this conversation as resolved.
Show resolved Hide resolved
from .providers import ZookeeperTenantProvider
self.Providers.append(ZookeeperTenantProvider(self.App, self, Config["tenants"]))


async def _every_five_minutes(self, message_type=None):
await self.update_tenants()
Expand Down
Loading