Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Zookeeper Provider for Tenants #661

Merged
merged 4 commits into from
Jan 15, 2025
Merged

Zookeeper Provider for Tenants #661

merged 4 commits into from
Jan 15, 2025

Conversation

language-shprt
Copy link
Contributor

@language-shprt language-shprt commented Jan 9, 2025 •
edited
Loading

Adds Zookeeper as the 3rd provider for asab.TenantService.
Returns Tenant IDs loaded from a dedicated ZK node.
Merge after this PR is ready and merged: #652

This change will require:

  • usual configuration in [zookeeper] section and
  • an additional (new) configuration in [tenants] section:
[zookeeper]
servers=zookeeper-1:2181

[tenants]
zk_path=XXXXX

@language-shprt language-shprt self-assigned this Jan 9, 2025
byewokko
byewokko requested changes Jan 10, 2025
View reviewed changes
asab/web/tenant/providers/zookeeper.py Outdated Show resolved Hide resolved
asab/web/tenant/providers/zookeeper.py Outdated Show resolved Hide resolved
byewokko
byewokko approved these changes Jan 10, 2025
View reviewed changes
Copy link
Collaborator

@byewokko byewokko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, let's merge after #652

Base automatically changed from feature/tenants-ready-status to master January 14, 2025 17:56
@language-shprt language-shprt merged commit ded1067 into master Jan 15, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@byewokko byewokko byewokko approved these changes

Assignees

@language-shprt language-shprt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@language-shprt @byewokko