Allow multiple biome placement/surface generation files per namespace in datapacks #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's taken me a bit to get around to checking, but it seems like this PR breaks the API (i.e. does not support loading the existing json files). The API for v3.0 was stabilized on July 5th. I can merge this when I make the next alpha release, probably whenever Mojang resumes releasing major breaking changes. |
|
I think there's an extra loop left in the surface rule one. I'll merge it and then figure it out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With large datapacks that have many biomes, having all biome placement/surface generation data in one file each gets very difficult to maintain and edit. This PR alleviates that by having biome placement and surface generation files in their own folders. Instead of having
data/namespace/biolith/biome_placement.json, you can havedata/namespace/biolith/biome_placement/whatever_you_want.json.