Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: 国际化支持 (closed #262) #265

Open
wants to merge 1 commit into
base: v1.0.24-rc
Choose a base branch
from

Conversation

CohleRustW
Copy link
Collaborator

No description provided.

@CohleRustW CohleRustW requested a review from ZhuoZhuoCrayon May 23, 2023 11:18
@CohleRustW
Copy link
Collaborator Author

第一版:麻烦简单 review 即可

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (v1.0.24-rc@67de320). Click here to learn what that means.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             v1.0.24-rc     #265   +/-   ##
=============================================
  Coverage              ?   40.44%           
=============================================
  Files                 ?      182           
  Lines                 ?     9223           
  Branches              ?        0           
=============================================
  Hits                  ?     3730           
  Misses                ?     5493           
  Partials              ?        0           



class BaseActivityManager(object):
def __init__(self, job: Job, job_task: JobTask, *args, **kwargs):
self.job = job
self.job_task = job_task

def inject_vars_to_global_data(self, global_pipeline_data: builder.Data, meta: Dict[str, Any]):
Copy link
Member

@ZhuoZhuoCrayon ZhuoZhuoCrayon May 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

在这里注入是无效的,这段逻辑并没有被用到

企业微信截图_334f3b19-1601-4525-8ee3-c2e1398818de

可以参考:
企业微信截图_d7db55a5-e9c4-47f5-9a73-f6fe9ba6a714


#: apps/gsekit/cmdb/handlers/cmdb.py:568
msgid "【当前实例对象】"
msgstr "【current instance object】"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

单个词组,至少是首字母要大写

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants