Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ios): optimize cell creation time of listview and waterfall #3639

Merged
merged 2 commits into from
Nov 30, 2023
Merged

fix(ios): optimize cell creation time of listview and waterfall #3639

merged 2 commits into from
Nov 30, 2023

Conversation

wwwcg
Copy link
Collaborator

@wwwcg wwwcg commented Nov 27, 2023

Before submitting a new pull request, please make sure:

  • Test cases have been added/updated/passed for the code you will submit.
  • Documentation has added or updated.
  • Commit message is following the Convention Commit guideline with maximum 72 characters.
  • Squash the repeat code commits, short patches are welcome.

@wwwcg wwwcg requested a review from ruifanyuan as a code owner November 27, 2023 06:27
@github-actions github-actions bot added renderer: native size: s Denotes a PR that changes 10-99 lines labels Nov 27, 2023
@hippy-service Hippy Service
Copy link

hippy-service bot commented Nov 27, 2023

Hi, @wwwcg. Thanks for your PR! 👏

🏷️ You can leave a comment in this PR with #help tag when you need help (e.g. some status checks run failed due to internal issue), admin team members will help asap.

@hippy-service Hippy Service
Copy link

hippy-service bot commented Nov 29, 2023

🎉 It seems that this pull request has been approved by all required reviewers. But it has more than one normal commit, I will notify admin team member to merge it manually, please wait a moment.

@wwwcg wwwcg added the action(rebase-merge) Rebase and merge action (maybe privileged) label Nov 30, 2023
@hippy-actions Hippy Actions
Copy link

hippy-actions bot commented Nov 30, 2023

🔒 rebase-merge action execution needs privilege escalation.

Please wait for admin team member approval ...

@wwwcg

@wwwcg wwwcg had a problem deploying to github-actions-privileged November 30, 2023 03:43 — with GitHub Actions Failure
@zealotchen0 zealotchen0 merged commit 4753e3b into Tencent:main Nov 30, 2023
24 of 26 checks passed
@hippy-actions hippy-actions bot added action(rebase-merge): failed Rebase and merge action execution failed and removed action(rebase-merge) Rebase and merge action (maybe privileged) labels Dec 30, 2023
@wwwcg wwwcg deleted the hippy3_fix_17 branch January 12, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruifanyuan ruifanyuan ruifanyuan approved these changes

Assignees
No one assigned
Labels
action(rebase-merge): failed Rebase and merge action execution failed renderer: native size: s Denotes a PR that changes 10-99 lines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wwwcg @ruifanyuan @zealotchen0