Fix: command option keep-outdated #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valentin-claras
force-pushed
the
fix/update-keep-outdated-to-boolean-remove-outdated
branch
from
e4fdcb7 to
f2b2caf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
The option
keep-outdateddoesn't work as it is a string compared to a boolean. Whatever its value, it's not going to be strictly equal tofalse(from the command line).How
We want to keep old value by default. And by putting the option, we expect to remove them.
Since a boolean value is expected, change the option to be a boolean option (without value), with a name matching the opposite of its default behavior.