Accessibility Project - Elina Eriksson Hult #543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 17 commits
August 23, 2024 22:45
…rove accessibility
ElinaEH
changed the title
HIPPIEKICK
approved these changes
Oct 10, 2024
There was a problem hiding this comment.
I'm glad you managed with the image in the end, I think this looks super! And I want to tell you, I can totally relate to wanting to see how it looks deployed (I have totally commited changes just to trigger a new deploy 😅
Now, to accessibility!
- Lighthouse report succeeded
- You have useful alt tags
- Contrasts are OK
Some suggestions for improvements:
- Why a button inside an
<a>? 👀 Can't see when that would be neccessary - Consider adding aria labels to improve accessibility for screen readers
Nothing you need to change now, just something to think about going forward!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://67028c384213c4000827a34d--effulgent-empanada-6d5956.netlify.app/