Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

project-news-site #536

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

project-news-site #536

wants to merge 11 commits into from

Conversation

joheri1
Copy link

@joheri1 joheri1 commented Aug 26, 2024

No description provided.

@JennieDalgren JennieDalgren self-assigned this Aug 29, 2024
Copy link
Collaborator

@JennieDalgren JennieDalgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing Netlify link

@joheri1
Copy link
Author

joheri1 commented Aug 29, 2024

Hi,

Can you see the README file now? I tried to add a new one.

//Johanna

@joheri1 joheri1 requested a review from JennieDalgren August 29, 2024 18:58
@joheri1
Copy link
Author

joheri1 commented Aug 29, 2024

Missing Netlify link

I tried to add a new README file. I hope you can see it. In case you don't, here's my Netlify link: https://main--farmersnews.netlify.app/ 😅

Copy link
Collaborator

@JennieDalgren JennieDalgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job with this project! You have met all requirements.

Nice work using both flex and grid. One thing, you don't need to use grid-gap. gap this the thing nowadays, and work on both grids and flexboxes.

Your code is clean and easy to follow and you are using comments in a good way.

Fun with the AI generated farm images 😉

Keep up the good work! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants