Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] 광고 상세 조회 API - #71 #81

Merged
merged 4 commits into from
Jul 11, 2024
Merged

[FEAT] 광고 상세 조회 API - #71 #81

merged 4 commits into from
Jul 11, 2024

Conversation

rlarlgnszx
Copy link
Member

🔥Pull requests

⛳️ 작업한 브랜치

👷 작업한 내용

  • 광고 상세 조회 API
  • 광고 Controller 구현
  • 광고 Service 구현
  • 광고 Repository 구현

🚨 참고 사항

📟 관련 이슈

Copy link
Contributor

@gardening-y gardening-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!!!!!!

Comment on lines 32 to 34
return ResponseEntity
.status(HttpStatus.OK)
.body(advertismentService.getAdvertismentsDetail(advId));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

로직 분리하고.. ok() 써주세용

List<AdvImagesRes> images,
String title,
@JsonFormat(shape = JsonFormat.Shape.STRING, pattern = "yyyy.MM.dd", timezone = "Asia/Seoul")

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

띄어쓰기..

.build();
}

@Builder
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builder Access 설정이요!

@rlarlgnszx rlarlgnszx merged commit 1431634 into develop Jul 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] 광고 상세 조회 API
2 participants