[FEAT] 지난 & 다가올 데이트 일정 전체 조회 API 구현 - #38 #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rlarlgnszx
reviewed
Jul 11, 2024
| @@ -37,6 +42,15 @@ public void createDate(final Long userId, final DateCreateReq dateCreateReq) { | |||
| createDatePlace(date, dateCreateReq.places()); | |||
| } | |||
|
|
|||
| public DatesGetRes getDates(Long userId, String time) { | |||
| } | ||
|
|
||
| private int calculateDday(LocalDate date, LocalDate currentDate) { | ||
| return (int) ChronoUnit.DAYS.between(currentDate, date); |
There was a problem hiding this comment.
ChronoUnit 이건 날짜 차이를 int형으로 반환하는 건가요? (잘 몰라서 그렇습니다!)
There was a problem hiding this comment.
long 타입으로 반환해줘서 int 형으로 타입변환했습니다!
| LocalDate currentDate = LocalDate.now(); | ||
| List<Date> dates = fetchDatesByUserIdAndTime(userId, time, currentDate); | ||
| List<DateGetRes> dateGetResList = dates.stream() | ||
| .map(date -> createDateGetRes(date, currentDate)) |
There was a problem hiding this comment.
다가올 일정 인지 지난 데이트인지 상관없이 createDateGetRes를 통해서 d-day를 계산하는것 같습니다!
지난 일정에는 굳이 계산하는 로직이 필요 없을 것 같습니다!
There was a problem hiding this comment.
오 좋은 거 같습니다..! 지난 일정일 경우 -1이나 0과 같은 고정값으로 반환해도 좋을 것 같아요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔥Pull requests
⛳️ 작업한 브랜치
👷 작업한 내용
지난 & 다가올 데이트 일정 전체 조회 API를 구현했습니다.
@RequestParam의 String name으로 PAST/FUTURE을 받아 PAST일 경우 유저의 지난 일정을 전체 조회해주며, FUTURE일 경우 유저의 지나지 않은 일정을 전체 조회해줍니다.
API 재사용을 위해 각각의 상황을 @RequestParam로 받아 구현하게 됐습니다.
Jpa QueryDSL을 통해 각각의 필터에 해당하는 Date를 리스트로 받아오며, DateGetRes를 List로 받은 DatesGetRes를 응답으로 받습니다.
추가로 ChronoUnit.DAYS.between를 사용해서 두 날짜의 시간 차를 구해서 디데이를 반환해줬습니다.
🚨 참고 사항
📟 관련 이슈