Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT] 유저 프로필 조회 API(메인) - #57 #60

Merged
merged 4 commits into from
Jul 11, 2024
Merged

[FEAT] 유저 프로필 조회 API(메인) - #57 #60

merged 4 commits into from
Jul 11, 2024

Conversation

sjk4618
Copy link
Member

@sjk4618 sjk4618 commented Jul 10, 2024

🔥Pull requests

⛳️ 작업한 브랜치

👷 작업한 내용

  • 유저 프로필 조회 API(메인)
public class UserService {
    private final UserRepository userRepository;

    public UserInfoMainRes getUserInfoMain(final Long userId) {
        User foundUser = findUserById(userId);
        return UserInfoMainRes.of(foundUser.getName(), foundUser.getTotalPoint(), foundUser.getImageUrl());
    }

📟 관련 이슈

@sjk4618 sjk4618 self-assigned this Jul 10, 2024
rlarlgnszx
rlarlgnszx reviewed Jul 11, 2024
View reviewed changes
Copy link
Member

@rlarlgnszx rlarlgnszx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굿 👍 수고하셨습니다!

dateroad-api/src/main/java/org/dateroad/user/service/UserService.java Outdated
return UserInfoMainRes.of(foundUser.getName(), foundUser.getTotalPoint(), foundUser.getImageUrl());
}

private User findUserById(Long userId) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

혹시 여기서 final 붙여주시면 감사하겠습니다!

@sjk4618
[fix] conflict 해결 - #57
1aa39b8 
# Conflicts:
#	dateroad-api/src/main/java/org/dateroad/user/api/UserController.java
@sjk4618 sjk4618 merged commit 5af23fa into develop Jul 11, 2024
1 check passed
@sjk4618 sjk4618 deleted the feature/#57 branch July 11, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rlarlgnszx rlarlgnszx rlarlgnszx approved these changes

@gardening-y gardening-y Awaiting requested review from gardening-y

Assignees

@sjk4618 sjk4618

Labels
feat 성준
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEAT] 유저 프로필 조회 API(메인)
2 participants
@sjk4618 @rlarlgnszx