-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEAT] 메인 다가올 일정(1개) 조회 API - #58 #59
Merged
+89
−1
Merged
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
f7ac244
[feat] DateController에 가까운일정 메서드 구현 - #58
sjk4618 88f74a7
[feat] DTO 추가 - #58
sjk4618 5725396
[feat] 가까운 일정 가져오기 구현 - #58
sjk4618 b28376c
[feat] 가장 가까운 일정 가져오기 구현 - #58
sjk4618 197c573
[fix] 변수명 변경 - #58
sjk4618 8be9d99
[fix] conflict 해결 - #58
sjk4618 6bcd962
[fix] 같은 어노테이션 삭제 - #58
sjk4618 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
37 changes: 36 additions & 1 deletion
37
dateroad-api/src/main/java/org/dateroad/date/dto/response/DateGetNearestRes.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,37 @@ | ||
package org.dateroad.date.dto.response;public record DateGetNearestRes() { | ||
package org.dateroad.date.dto.response; | ||
|
||
import com.fasterxml.jackson.annotation.JsonFormat; | ||
import lombok.AccessLevel; | ||
import lombok.Builder; | ||
|
||
import java.time.LocalDate; | ||
import java.time.LocalDateTime; | ||
import java.time.LocalTime; | ||
|
||
@Builder(access = AccessLevel.PRIVATE) | ||
public record DateGetNearestRes( | ||
Long dateId, | ||
int dDay, | ||
String dateName, | ||
int month, | ||
int day, | ||
@JsonFormat(shape = JsonFormat.Shape.STRING, pattern = "hh:mm a", timezone = "Asia/Seoul") | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 여기도 a를 안받아주셔도 12:00 이렇게 매핑될 것 같습니다! |
||
LocalTime startAt | ||
) { | ||
public static DateGetNearestRes of(Long dateId, | ||
int dDay, | ||
String dateName, | ||
int month, | ||
int day, | ||
LocalTime startAt) { | ||
return DateGetNearestRes.builder() | ||
.dateId(dateId) | ||
.dDay(dDay) | ||
.dateName(dateName) | ||
.month(month) | ||
.day(day) | ||
.startAt(startAt) | ||
.build(); | ||
} | ||
|
||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
date에서 a값도 불필요하게 받아야 하는것 같습니다!
a를 빼주셔도 좋을 것 같아요!