Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in changelog.h #988

Merged
merged 1 commit into from
Aug 8, 2023
Merged

Fix typo in changelog.h #988

merged 1 commit into from
Aug 8, 2023

Conversation

jeffriley
Copy link
Collaborator

No description provided.

@jeffriley jeffriley requested a review from ilyamandel August 6, 2023 01:10
Copy link
Collaborator

@ilyamandel ilyamandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@avivajpeyi
Copy link
Collaborator

Looks like

py_tests/test_plot_detailed_evolution.py

failed due to a latex issue? This is bizarre -- nothing was changed in the python code...

@jeffriley
Copy link
Collaborator Author

Odd. Related to the docs build failure (which is now passing)? Both seemed to involve latex. Intermittent resource issue maybe?

@jeffriley
Copy link
Collaborator Author

@avivajpeyi Any ideas on this? Maybe we just turn the pytests off until we figure out what's going on?

@avivajpeyi
Copy link
Collaborator

Hey jeff, sure we can turn the pytest off -- or maybe just the detailed-plotter (that's where the error is being raised).

I've opened a new issue regarding this error #989

@ilyamandel
Copy link
Collaborator

I am going to merge this in despite the nominal fail, since this clearly isn't the issue.

@ilyamandel ilyamandel merged commit c704bcf into dev Aug 8, 2023
@ilyamandel ilyamandel deleted the typo_fix branch August 8, 2023 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants