Fixes initialisation in MS_gt_07::Initialise() for CORE_MASS_PRESCRIPTION::SHIKAUCHI #1326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…TION::SHIKAUCHI (now allows for CH stars that spin down)
jeffriley
added
bug
ilyamandel
approved these changes
Jan 29, 2025
There was a problem hiding this comment.
Looks good to me!
@jeffriley , I leave it to you and @brcekadam to decide whether to merge now or wait for Adam's review. :)
brcekadam
approved these changes
Jan 30, 2025
There was a problem hiding this comment.
Thanks @jeffriley! I tested it and everything looks good. I wasn't able to find a CH star that spins down, but there shouldn't be an issue anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MS_gt_07::Initialise() now allows for CH stars that spin down when initialisation done for CORE_MASS_PRESCRIPTION::SHIKAUCHI.
@brcekadam I haven't tested this other than for compilation - can you check that the CORE_MASS_PRESCRIPTION::SHIKAUCHI code functions as you expect. If you can find a CH star that spins down, you could check for that too (but don't worry too much if you can't find one easily).