Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defect repair - Fix for issue #1074 - SSE Supernova records duplicated #1092

Merged
merged 2 commits into from
Apr 15, 2024

Conversation

jeffriley
Copy link
Collaborator

@jeffriley jeffriley commented Apr 15, 2024

Fix for issue #1074 - SSE Supernova records duplicated

@jeffriley jeffriley added the bug Something isn't working label Apr 15, 2024
@jeffriley jeffriley added severity_moderate This is a moderately severe bug urgency_moderate This is a moderately urgent issue labels Apr 15, 2024
@jeffriley jeffriley linked an issue Apr 15, 2024 that may be closed by this pull request
Copy link
Collaborator

@ilyamandel ilyamandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yikes. I'll approve, but this business of stashing info, delayed writing, and having to occasionally clear stashes looks very susceptible to future issues where someone forgets to clear a stash (I certainly would have). I am not suggesting that I know a cleaner way, but I think this is primed to bite us again.

@jeffriley
Copy link
Collaborator Author

I agree @ilyamandel. The reason we stash and delay the write is because of the (COMPAS) SSE method of evolving and reverting if we decide we evolved too far - if we write directly to the file we might have written a record when we decide to revert, so we'd have to go and remove that record - easier to stash and delay the write. I'm hoping the c'ear stash' problem will be obviated with the work to resolve the COMPAS vs Hurley sse differences.

@jeffriley jeffriley merged commit e2c12cd into dev Apr 15, 2024
2 checks passed
@jeffriley jeffriley deleted the issue-1074 branch April 15, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working severity_moderate This is a moderately severe bug urgency_moderate This is a moderately urgent issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Supernova being recorded twice in SSE_Supernovae output
2 participants