Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1058 bug calculating NS spin period in NS.cpp #1059

Merged
merged 3 commits into from
Feb 2, 2024
Merged

1058 bug calculating NS spin period in NS.cpp #1059

merged 3 commits into from
Feb 2, 2024

Conversation

yuzhesong
Copy link
Collaborator

No description provided.

@yuzhesong yuzhesong linked an issue Jan 31, 2024 that may be closed by this pull request
Bug calculating NS spin period in NS.cpp #1058
Closed
ilyamandel
ilyamandel approved these changes Jan 31, 2024
View reviewed changes
Copy link
Collaborator

@ilyamandel ilyamandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good -- thanks for the fix, @yuzhesong !

@jeffriley jeffriley merged commit 2e5b108 into TeamCOMPAS:dev Feb 2, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilyamandel ilyamandel ilyamandel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug calculating NS spin period in NS.cpp
3 participants
@yuzhesong @ilyamandel @jeffriley