Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pre aic mass recording #1055

Merged
merged 4 commits into from
Mar 24, 2024
Merged

Fix pre aic mass recording #1055

merged 4 commits into from
Mar 24, 2024

Conversation

reinhold-willcox
Copy link
Collaborator

Resolves issue #1033.

Copy link
Collaborator

@ilyamandel ilyamandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@reinhold-willcox -- I am not sure I understand why the various core masses are set to zero on AIC; can you please explain your logic?
[Sorry for taking so long to review this because of travel...]

@reinhold-willcox
Copy link
Collaborator Author

@ilyamandel I've readded in the correct masses, sorry for that (and the delay).

@reinhold-willcox reinhold-willcox mentioned this pull request Mar 21, 2024
@reinhold-willcox reinhold-willcox marked this pull request as draft March 21, 2024 21:53
@ilyamandel ilyamandel merged commit 2e94a4b into dev Mar 24, 2024
2 checks passed
@ilyamandel ilyamandel deleted the fix_preAicMassRecording branch March 24, 2024 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants