Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect orbital evolution on mass loss #1305

Closed
ilyamandel opened this issue Dec 5, 2024 · 2 comments
Closed

Incorrect orbital evolution on mass loss #1305

ilyamandel opened this issue Dec 5, 2024 · 2 comments
Assignees
Labels
bug Something isn't working severity_major This is a severe bug urgency_high This is a very urgent issue and should be resolved as soon as possible

Comments

@ilyamandel
Copy link
Collaborator

When a binary (no tides, no GWs, no supernovae, no mass transfer) loses mass in winds or pulsations on timescales much longer than the orbital timescale, M_total * a should be conserved. I've tested this before, but now it's not conserved, again. :(

The following example was created with ./COMPAS -n 1 --detailed-output --random-seed 1733362410

Part of the issue is that the binary evolution on wind mass loss is unnecessarily approximate, yielding wiggles (not visible on the plot without zooming in). I fixed that in #1304 (draft for now). But there's clearly a bigger issue when the star loses a lot of mass in pulsations on the TPAGB, leading to full envelope loss. To be fixed [I'll work on this, just listing @SimonStevenson , @reinhold-willcox , @jeffriley FYI .]

image

@ilyamandel ilyamandel self-assigned this Dec 5, 2024
@ilyamandel ilyamandel added bug Something isn't working severity_major This is a severe bug urgency_high This is a very urgent issue and should be resolved as soon as possible labels Dec 5, 2024
ilyamandel pushed a commit that referenced this issue Dec 12, 2024
@ilyamandel
Copy link
Collaborator Author

Fix completed, maximum fractional change in a*M is now 0.0few percent (see plot below).

The main issue was that we would sometimes create a WD as an outcome of a supernova: if the Hurley criteria called for an ECSN, but we didn't meet the mass transfer history threshold for an ECSN proposed by @reinhold-willcox , ResolveElectronCaptureSupernova() would yield an ONeWD. That is inconsistent with the Hurley evolution in the HR diagram, and is also inconsistent with the idea that a WD is formed by gradual mass loss, not a rapid, explosive SN. For now, the fix is that if the ECSN criteria are not met, we go through a "standard" SN.

@ilyamandel
Copy link
Collaborator Author

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working severity_major This is a severe bug urgency_high This is a very urgent issue and should be resolved as soon as possible
Projects
None yet
Development

No branches or pull requests

1 participant