Incorrect orbital evolution on mass loss #1305
Labels
bug
Something isn't working
severity_major
This is a severe bug
urgency_high
This is a very urgent issue and should be resolved as soon as possible
When a binary (no tides, no GWs, no supernovae, no mass transfer) loses mass in winds or pulsations on timescales much longer than the orbital timescale, M_total * a should be conserved. I've tested this before, but now it's not conserved, again. :(
The following example was created with
./COMPAS -n 1 --detailed-output --random-seed 1733362410
Part of the issue is that the binary evolution on wind mass loss is unnecessarily approximate, yielding wiggles (not visible on the plot without zooming in). I fixed that in #1304 (draft for now). But there's clearly a bigger issue when the star loses a lot of mass in pulsations on the TPAGB, leading to full envelope loss. To be fixed [I'll work on this, just listing @SimonStevenson , @reinhold-willcox , @jeffriley FYI .]
The text was updated successfully, but these errors were encountered: