Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch stellar type to massless remnant on merger in common envelope #1265

Closed
ilyamandel opened this issue Oct 29, 2024 · 1 comment
Closed

Switch stellar type to massless remnant on merger in common envelope #1265

ilyamandel opened this issue Oct 29, 2024 · 1 comment
Assignees
@jeffriley

Comments

@ilyamandel
Copy link
Collaborator

This will ensure that mergers are recorded in switch logs, and also that the post-merger stellar type is correctly recorded in the BSE_Common_Envelopes output
@ilyamandel ilyamandel mentioned this issue Nov 28, 2024
Merged
@ilyamandel
Copy link
Collaborator Author

Resolved in #1291 , closing.

ilyamandel pushed a commit that referenced this issue Nov 28, 2024
Switch both stars to Massless remnants during a CE merger, resolve #1265
1a412ce
jeffriley added a commit that referenced this issue Nov 28, 2024
@jeffriley
Merge pull request #1291 from TeamCOMPAS/Output
e3f130a 
A range of fixes: using core radii for CE survival, fixes to #1255, #1258, #1265
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeffriley jeffriley

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ilyamandel @jeffriley