Changed the prescription for Tonset in the Picker+ models to take adv…

…antage of improved metallicity-dependent fits
TeamCOMPAS · Oct 7, 2024 · ddb3300 · ddb3300
1 parent ac31692
commit ddb3300
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/src/GiantBranch.cpp b/src/GiantBranch.cpp
@@ -1089,9 +1089,9 @@ DBL_DBL GiantBranch::CalculateConvectiveEnvelopeMass() const {
     double Tmin = clone->Temperature();                                                                                     // get temperature of clone
     delete clone; clone = nullptr;                                                                                          // return the memory allocated for the clone
 
-    // Assume Tonset is always 0.1 dex hotter than Tmin, to avoid issues caused by differences between temperatures
-    // in MESA models (used in Picker+ fits) and Pols models (used in Hurley+ SSE tracks), rather than Eq. (6) of Picker+ 2024
-    double Tonset     = 1.2589 * Tmin;
+    // Use Eq. 6 of Mandel, Hirai, Picker (2024) rather than Eq. 6 of Picker+ 2024 for Tonset to avoid issues caused by
+    // differences between temperatures in MESA models (used in Picker+ fits) and Pols models (used in Hurley+ SSE tracks)
+    double Tonset     = Tmin / std::min(0.0695 - 0.057 * m_Log10Metallicity, 0.95);                                         // eq. (6) of Mandel, Hirai, Picker, 2024
 
     double mCoreFinal = CalculateCoreMassAtBAGB(m_Mass0);
     double mConvMax   = std::max(m_Mass - mCoreFinal * (1.0 + MinterfMcoref), 0.0);                                         // eq. (9) of Picker+ 2024

diff --git a/src/changelog.h b/src/changelog.h
@@ -1340,7 +1340,9 @@
 //                                        output file post-stellar timestep was removed, and one was added per-stellar timestep.  The post-stellar timestep print was removed because
 //                                        with the code as it is currently it would be redundant with the post-timestep print, but because we may add code in the future the constant
 //                                        POST_STELLAR_TIMESTEP was left in enum class BSE_DETAILED_RECORD_TYPE in LogTypedefs.h.
+// 03.05.01   IM - Oct 07, 2024     - Enhancement:
+//                                      - Changed the prescription for Tonset in the Picker+ models to take advantage of improved metallicity-dependent fits 
 
-const std::string VERSION_STRING = "03.05.00";
+const std::string VERSION_STRING = "03.05.01";
 
 # endif // __changelog_h__