Skip to content

Commit

Permalink
pulled changelog from dev branch to avoid merge conflicts
Browse files Browse the repository at this point in the history
  • Loading branch information
veome22 committed Apr 8, 2024
2 parents fd038ce + eeda005 commit cc1be8c
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 2 deletions.
2 changes: 1 addition & 1 deletion src/BaseStar.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1775,7 +1775,7 @@ double BaseStar::CalculateMassLossRateBjorklundEddingtonFactor() const {
const double YHe = 0.1; // Assumed constant by Bjorklund et al.
double kappa_e = 0.4 * (1.0 + iHe * YHe) / (1.0 + 4.0 * YHe); // cm^2/g
double kappa_e_SI = kappa_e * OPACITY_CGS_TO_SI; // m^2/kg
double top = kappa_e_SI * m_Luminosity * LSOL;
double top = kappa_e_SI * m_Luminosity * LSOLW;
double bottom = 4.0 * M_PI * G * C * m_Mass * MSOL_TO_KG;

return top / bottom;
Expand Down
5 changes: 4 additions & 1 deletion src/changelog.h
Original file line number Diff line number Diff line change
Expand Up @@ -1113,8 +1113,11 @@
// - Defect repair : Added explicit definition `bool isUnstable = false` to avoid confusion in BaseBinaryStar.cpp
// - Defect repair : Fixed erroneous core mass values in ResolveSNIa in WhiteDwarfs.cpp. Was previously 0 for all core masses.
// - Enhancement: Added output parameter TZAMS for internal variable m_TZAMS
// 02.43.00 RTW - Mar 29, 2023 - Enhancement:
// 02.43.00 RTW - Mar 29, 2024 - Enhancement:
// - Added Hirai pulsar rocket kick, and related options
// 02.43.01 SS - Apr 8, 2024 - Defect repair
// - Fix CalculateMassLossRateBjorklundEddingtonFactor to use LSOLW (in SI) rather than LSOL (in cgs)
//
// 02.44.00 VK - Apr 04, 2024 - Enhancement:
// - Added 'realistic' tides option, which implements dynamical tides. Functionality enabled with new option `--enable-realistic-tides`. Default is no tides.
// - Dynamcial tides implementation follows Zahn, 1977, Eq. (5.5) , with the value of E_2 coming from Kushnir et al., 2017, Eq. (8).
Expand Down

0 comments on commit cc1be8c

Please sign in to comment.