From f075ee2cddbaf598649164f0b4a3598e47fbe362 Mon Sep 17 00:00:00 2001 From: Avi Vajpeyi Date: Wed, 11 Sep 2024 11:49:38 +1200 Subject: [PATCH 1/2] Add comment about orig cosmic integration param name This variable name changed from Coen's initial implementation. Adding a comment to help future readers. --- .../cosmic_integration/FastCosmicIntegration.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/compas_python_utils/cosmic_integration/FastCosmicIntegration.py b/compas_python_utils/cosmic_integration/FastCosmicIntegration.py index 5450d9ea4..121bbedd2 100644 --- a/compas_python_utils/cosmic_integration/FastCosmicIntegration.py +++ b/compas_python_utils/cosmic_integration/FastCosmicIntegration.py @@ -92,9 +92,9 @@ def find_metallicity_distribution(redshifts, min_logZ_COMPAS, max_logZ_COMPAS, min_logZ_COMPAS --> [float] Minimum logZ value that COMPAS samples max_logZ_COMPAS --> [float] Maximum logZ value that COMPAS samples - mu0 = 0.035 --> [float] location (mean in normal) at redshift 0 - muz = -0.23 --> [float] redshift scaling/evolution of the location - sigma_0 = 0.39 --> [float] Scale (variance in normal) at redshift 0 + mu0 = 0.035 --> [float] location (mean in normal) at redshift 0 + muz = -0.23 --> [float] redshift scaling/evolution of the location (alpha in Neijssel+19) + sigma_0 = 0.39 --> [float] Scale (variance in normal) at redshift 0 (sigma in Neijssel+19) sigma_z = 0.00 --> [float] redshift scaling of the scale (variance in normal) alpha = 0.00 --> [float] shape (skewness, alpha = 0 retrieves normal dist) From 4d53510360424657983c1a38b045068f39524b35 Mon Sep 17 00:00:00 2001 From: Ilya Mandel Date: Wed, 11 Sep 2024 09:20:41 +0200 Subject: [PATCH 2/2] Update FastCosmicIntegration.py Added extra comments. --- .../cosmic_integration/FastCosmicIntegration.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/compas_python_utils/cosmic_integration/FastCosmicIntegration.py b/compas_python_utils/cosmic_integration/FastCosmicIntegration.py index 121bbedd2..e3724e5ab 100644 --- a/compas_python_utils/cosmic_integration/FastCosmicIntegration.py +++ b/compas_python_utils/cosmic_integration/FastCosmicIntegration.py @@ -95,8 +95,8 @@ def find_metallicity_distribution(redshifts, min_logZ_COMPAS, max_logZ_COMPAS, mu0 = 0.035 --> [float] location (mean in normal) at redshift 0 muz = -0.23 --> [float] redshift scaling/evolution of the location (alpha in Neijssel+19) sigma_0 = 0.39 --> [float] Scale (variance in normal) at redshift 0 (sigma in Neijssel+19) - sigma_z = 0.00 --> [float] redshift scaling of the scale (variance in normal) - alpha = 0.00 --> [float] shape (skewness, alpha = 0 retrieves normal dist) + sigma_z = 0.00 --> [float] redshift scaling of the scale (variance in normal, 0 in Neijssel+19) + alpha = 0.00 --> [float] shape (skewness, alpha = 0 retrieves normal dist as in Neijssel+19) min_logZ --> [float] Minimum logZ at which to calculate dPdlogZ (influences normalization) max_logZ --> [float] Maximum logZ at which to calculate dPdlogZ (influences normalization)