Skip to content

Commit

Permalink
combined fixes for AIC mass recording, isUnstable ambiguity, and addi…
Browse files Browse the repository at this point in the history
…ng Teff@ZAMS to possible output
  • Loading branch information
reinhold-willcox committed Mar 21, 2024
2 parents 2e94a4b + faeeafc commit 35c9128
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 3 deletions.
2 changes: 1 addition & 1 deletion src/BaseBinaryStar.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1879,7 +1879,7 @@ void BaseBinaryStar::CalculateMassTransfer(const double p_Dt) {
bool accretorIsWD = m_Accretor->IsOneOf(WHITE_DWARFS);

// Determine stability
bool isUnstable;
bool isUnstable = false;
if (donorIsHeHGorHeGB && (caseBBAlwaysStable || caseBBAlwaysUnstable || (caseBBAlwaysUnstableOntoNSBH && accretorIsNSorBH))) { // Determine stability based on case BB
isUnstable = (caseBBAlwaysUnstable || (caseBBAlwaysUnstableOntoNSBH && accretorIsNSorBH)); // Already established that donor is HeHG or HeGB - need to check if new case BB prescriptions are added
}
Expand Down
6 changes: 4 additions & 2 deletions src/changelog.h
Original file line number Diff line number Diff line change
Expand Up @@ -1109,8 +1109,10 @@
// - calling code for MassLossToFitInsideRocheLobe() and Mass0ToMatchDesiredCoreMass() now handles -ve return:
// - if MassLossToFitInsideRocheLobe() returns -ve value (i.e. no root found), the binary immediately enters a CE phase
// - if Mass0ToMatchDesiredCoreMass() returns -ve value (i.e. no root found), an arbitrary value is used for core mass (see code for value)
// 02.42.02 RTW - Mar 21, 2024 - Minor enhancement:
// - Added output parameter TZAMS for internal variable m_TZAMS
// 02.42.02 RTW - Mar 21, 2024 - Minor edits:
// - Defect repair : Added explicit definition `bool isUnstable = false` to avoid confusion in BaseBinaryStar.cpp
// - Defect repair : Fixed erroneous core mass values in ResolveSNIa in WhiteDwarfs.cpp. Was previously 0 for all core masses.
// - Enhancement: Added output parameter TZAMS for internal variable m_TZAMS

const std::string VERSION_STRING = "02.42.02";

Expand Down

0 comments on commit 35c9128

Please sign in to comment.