Slipping detection #193
Open
Slipping detection #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #193 +/- ##
==========================================
+ Coverage 71.65% 71.97% +0.32%
==========================================
Files 84 85 +1
Lines 1623 1638 +15
Branches 151 151
==========================================
+ Hits 1163 1179 +16
+ Misses 460 459 -1
Continue to review full report at Codecov.
|
PhilipAxelrod
requested changes
Mar 17, 2018
| implicit val (clock, triggerClock) = ClockMocking.mockedClockTicker | ||
| val period = Milliseconds(5) | ||
|
|
||
| test("left and right slipping") { |
There was a problem hiding this comment.
Please include more descriptive test names that describe the specific parameters and conditions you are testing. For example, "test no slipping detected with no linear or angular acceleration
| val angularVelocity: Stream[AngularVelocity] = Stream.periodic(period)(RadiansPerSecondSquared(5)).integral | ||
| val linearAcceleration: Stream[Acceleration] = Stream.periodic(period)(FeetPerSecondSquared(5)) | ||
| val leftEncoderVelocity: Stream[Velocity] = Stream.periodic(period)(FeetPerSecondSquared(2)).integral | ||
| val rightEncoderVelocity: Stream[Velocity] = Stream.periodic(period)(FeetPerSecondSquared(9.5)).integral |
There was a problem hiding this comment.
Please use smaller, easier to compute numbers to avoid mistakes in unit tests.
|
|
||
| triggerClock.apply(period) | ||
| triggerClock.apply(period) | ||
| triggerClock.apply(period) |
There was a problem hiding this comment.
Why do you call apply so many times?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.