Tracks how long for the motor to reach setpoint #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZachOrr
requested changes
Feb 20, 2022
ZachOrr
reviewed
Feb 20, 2022
ZachOrr
reviewed
Feb 20, 2022
ZachOrr
reviewed
Feb 20, 2022
ZachOrr
reviewed
Feb 20, 2022
ZachOrr
requested changes
Feb 20, 2022
| @Override | ||
| public void execute() { | ||
| shooter.setSpeed(shooter.shooterSpeedFeetPerSecondWidget.getDouble(0)); | ||
| double targetSetpoint = shooter.shooterSpeedFeetPerSecondWidget.getDouble(0); | ||
| newSetpoint = targetSetpoint; |
There was a problem hiding this comment.
So if we're never resetting our reachSetpointCycleCounter or isShooterComingUpToSpeed - do we need to have a previous/next here? Or can we just have the single setpoint?
Doing the zeroing/resetting the way you were doing is fine. You'd only have to move your SmartDashboard.putNumber back in to that if (isShooterComingUpToSpeed block for that to still work.
Either approach is fine here IMO. I don't know if at this point in time we'll be like, holding the button to start the shooter and changing the values on the slider. I think it's more likely we'll set the value in code and then want to see how long the shooter takes to get up to speed between StartShooter calls.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.