[FEAT] 에러 핸들 케이스 추가 #136

Team-Umbba · Mar 7, 2024 · 5dee54a · 5dee54a
1 parent 130265a
commit 5dee54a
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 2 deletions.
diff --git a/umbba-api/src/main/java/sopt/org/umbba/api/controller/closer/CloserController.java b/umbba-api/src/main/java/sopt/org/umbba/api/controller/closer/CloserController.java
@@ -18,7 +18,8 @@
 import static sopt.org.umbba.common.exception.SuccessType.PASS_TO_NEXT_CLOSER_QUESTION_SUCCESS;
 
 @Slf4j
-@RestController("/closer")
+@RestController
+@RequestMapping("/closer")
 @RequiredArgsConstructor
 public class CloserController {
 

diff --git a/...rc/main/java/sopt/org/umbba/domain/domain/closer/repository/CloserQuestionRepository.java b/...rc/main/java/sopt/org/umbba/domain/domain/closer/repository/CloserQuestionRepository.java
@@ -1,6 +1,8 @@
 package sopt.org.umbba.domain.domain.closer.repository;
 
 import org.springframework.data.jpa.repository.JpaRepository;
+import sopt.org.umbba.common.exception.ErrorType;
+import sopt.org.umbba.common.exception.model.CustomException;
 import sopt.org.umbba.domain.domain.closer.CloserQuestion;
 
 import java.util.List;
@@ -15,6 +17,9 @@ default Optional<CloserQuestion> findRandomExceptIds(List<Long> ids) {
         Random random = new Random();
         List<CloserQuestion> allQuestions = findAll();
 
+        if (allQuestions.isEmpty()) {
+            throw new CustomException(ErrorType.NOT_FOUND_CLOSER_QUESTION);
+        }
         if (ids.isEmpty()) {
             int randomIndex = random.nextInt(allQuestions.size());
             return Optional.ofNullable(allQuestions.get(randomIndex));

diff --git a/umbba-domain/src/main/java/sopt/org/umbba/domain/domain/parentchild/Parentchild.java b/umbba-domain/src/main/java/sopt/org/umbba/domain/domain/parentchild/Parentchild.java
@@ -56,7 +56,7 @@ public void addRemindCnt() {
         this.remindCnt += 1;
     }
 
-    @OneToMany(fetch = FetchType.EAGER)
+    @OneToMany
     @JoinColumn(name = "parentchild_id")
     private List<CloserQnA> closerQnaList;