Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT] 행복루틴 추가 #78

Merged
merged 10 commits into from
Jan 12, 2024
Merged

[FEAT] 행복루틴 추가 #78

merged 10 commits into from
Jan 12, 2024

Conversation

csb9427
Copy link
Contributor

@csb9427 csb9427 commented Jan 11, 2024 •
edited
Loading

✨ Related Issue

📝 기능 구현 명세

image

🐥 추가적인 언급 사항

해결...

@csb9427 csb9427 added feature 기능 개발 hold review 리뷰 보류 (이전 PR 영향을 받을 때) seungbin 승빈 작업 labels Jan 11, 2024
@csb9427 csb9427 removed the hold review 리뷰 보류 (이전 PR 영향을 받을 때) label Jan 12, 2024
@csb9427 csb9427 requested review from thguss and Chan531 January 12, 2024 08:16
Chan531
Chan531 approved these changes Jan 12, 2024
View reviewed changes
Copy link
Contributor

@Chan531 Chan531 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다~!

thguss
thguss reviewed Jan 12, 2024
View reviewed changes
Copy link
Member

@thguss thguss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다~ 타입과 메소드명 하나만 수정하면 좋을 것 같아요-!
수정 후 재언급 부탁드려요 :)

src/main/java/com/soptie/server/memberRoutine/controller/MemberHappinessRoutineController.java Outdated Show resolved Hide resolved
src/main/java/com/soptie/server/memberRoutine/service/MemberHappinessRoutineServiceImpl.java Outdated Show resolved Hide resolved
thguss
thguss approved these changes Jan 12, 2024
View reviewed changes
Copy link
Member

@thguss thguss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다!

@csb9427 csb9427 merged commit bad3c4a into develop Jan 12, 2024
1 check passed
@csb9427 csb9427 deleted the feature/#58-happiness-routine-post-api branch January 12, 2024 14:24
@frohsch
Copy link

frohsch commented Jan 14, 2024

행 복 해 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thguss thguss thguss approved these changes

@Chan531 Chan531 Chan531 approved these changes

Assignees

@csb9427 csb9427

Labels
feature 기능 개발 seungbin 승빈 작업
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[POST] 행복루틴 추가
4 participants
@csb9427 @frohsch @thguss @Chan531