Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#40 [ui] 온보딩 테마&루틴 선택 뷰 수정 #41

Merged
merged 4 commits into from
Jan 13, 2024
Merged

#40 [ui] 온보딩 테마&루틴 선택 뷰 수정 #41

merged 4 commits into from
Jan 13, 2024

Conversation

emjayMJkim
Copy link
Member

@emjayMJkim emjayMJkim commented Jan 12, 2024 •
edited
Loading

📑 Work Description

  • 테마 선택 뷰 리사이클러뷰가 스크롤되는 이슈
  • 루틴 선택 뷰 위아래 그라데이션 & 버튼 잘림 이슈

🛠️ Issue

📷 Screenshot

fix.btn.non.outlineprovider.mp4

💬 To Reviewers

화면 상에서 자잘한 이슈 있는 부분 더 생기면 올리겠습니다

@emjayMJkim emjayMJkim self-assigned this Jan 12, 2024
@emjayMJkim emjayMJkim added UI ui 관련 작업 Pull Request pr 날림! 민정🦊 민정이가 작업함! fix Fix(디자인 등) labels Jan 12, 2024
stellar-halo
stellar-halo approved these changes Jan 12, 2024
View reviewed changes
Copy link
Contributor

@stellar-halo stellar-halo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

좋아요! 디테일 꼼꼼하게 멋잇습니다~

pump9918
pump9918 approved these changes Jan 12, 2024
View reviewed changes
Copy link
Collaborator

@pump9918 pump9918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

사소한 디테일도 놓치지 않는 갓기..

minemi00
minemi00 approved these changes Jan 12, 2024
View reviewed changes
Copy link
Member

@minemi00 minemi00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

그라데이션 폼 미쳤다

@emjayMJkim emjayMJkim merged commit cb152cd into develop Jan 13, 2024
1 check passed
@emjayMJkim emjayMJkim deleted the feature/#40-fix-issue branch January 13, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stellar-halo stellar-halo stellar-halo approved these changes

@pump9918 pump9918 pump9918 approved these changes

@minemi00 minemi00 minemi00 approved these changes

Assignees

@emjayMJkim emjayMJkim

Labels
fix Fix(디자인 등) Pull Request pr 날림! UI ui 관련 작업 민정🦊 민정이가 작업함!
Projects
Softie Android
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[fix] 자잘한 이슈 해결
4 participants
@emjayMJkim @stellar-halo @pump9918 @minemi00