Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unexpected<E> should provide the member function error() #149

Open
William8915 opened this issue Jul 6, 2023 · 0 comments · May be fixed by #167
Open

unexpected<E> should provide the member function error() #149

William8915 opened this issue Jul 6, 2023 · 0 comments · May be fixed by #167

Comments

@William8915
Copy link

William8915 commented Jul 6, 2023 •
edited
Loading

According to https://en.cppreference.com/w/cpp/utility/expected/unexpected, The C++23 standard uses the member function error() to access the stored E inside unexpected<E>. The library currently uses value() which is inconsistent.
jogerh added a commit to jogerh/expected that referenced this issue Feb 19, 2025
@jogerh
Rename tl::unexpected::value() to tl::unexpected::error()
14c70a6 
Fixes TartanLlama#149
@jogerh jogerh linked a pull request Feb 19, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename tl::unexpected::value() to tl::unexpected::error() jogerh/expected
1 participant
@William8915