Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(query-core): use fakeTimers for infiniteQueryBehavior.test.tsx #8961

Merged
merged 5 commits into from
Apr 12, 2025
Merged

test(query-core): use fakeTimers for infiniteQueryBehavior.test.tsx #8961

merged 5 commits into from
Apr 12, 2025
+23 −15

Conversation

manudeli
Copy link
Contributor

@manudeli manudeli commented Apr 6, 2025

No description provided.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Apr 6, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 3202f1b.

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 5m 20s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 2m 6s View ↗

☁️ Nx Cloud last updated this comment at 2025-04-12 16:32:32 UTC

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Apr 6, 2025 •
edited
Loading

More templates

@tanstack/angular-query-devtools-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@8961

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@8961

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@8961

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@8961

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@8961

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@8961

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@8961

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@8961

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@8961

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@8961

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@8961

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@8961

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@8961

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@8961

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@8961

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@8961

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@8961

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@8961

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@8961

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@8961

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@8961

commit: 3202f1b

@TkDodo
Copy link
Collaborator

TkDodo commented Apr 6, 2025

this one seems to timeout:

   × InfiniteQueryBehavior > InfiniteQueryBehavior should not enter an infinite loop when a page errors while retry is on #8046 5007ms
     → Test timed out in 5000ms.

@codecov Codecov
Copy link

codecov bot commented Apr 6, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.54%. Comparing base (38178ba) to head (3202f1b).
Report is 9 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #8961       +/-   ##
===========================================
+ Coverage   44.18%   58.54%   +14.35%     
===========================================
  Files         202      137       -65     
  Lines        8063     5317     -2746     
  Branches     1775     1398      -377     
===========================================
- Hits         3563     3113      -450     
+ Misses       4068     1915     -2153     
+ Partials      432      289      -143
Components Coverage Δ
@tanstack/angular-query-devtools-experimental ∅ <ø> (∅)
@tanstack/angular-query-experimental 88.08% <ø> (ø)
@tanstack/eslint-plugin-query ∅ <ø> (∅)
@tanstack/query-async-storage-persister 43.85% <ø> (ø)
@tanstack/query-broadcast-client-experimental ∅ <ø> (∅)
@tanstack/query-codemods ∅ <ø> (∅)
@tanstack/query-core 94.82% <ø> (ø)
@tanstack/query-devtools 3.61% <ø> (ø)
@tanstack/query-persist-client-core 73.46% <ø> (ø)
@tanstack/query-sync-storage-persister 84.61% <ø> (ø)
@tanstack/react-query 95.42% <ø> (ø)
@tanstack/react-query-devtools 10.00% <ø> (ø)
@tanstack/react-query-next-experimental ∅ <ø> (∅)
@tanstack/react-query-persist-client 100.00% <ø> (ø)
@tanstack/solid-query 78.48% <ø> (ø)
@tanstack/solid-query-devtools ∅ <ø> (∅)
@tanstack/solid-query-persist-client 100.00% <ø> (ø)
@tanstack/svelte-query 88.15% <ø> (ø)
@tanstack/svelte-query-devtools ∅ <ø> (∅)
@tanstack/svelte-query-persist-client 100.00% <ø> (ø)
@tanstack/vue-query 71.01% <ø> (ø)
@tanstack/vue-query-devtools ∅ <ø> (∅)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@manudeli
Copy link
Contributor Author

manudeli commented Apr 6, 2025

this one seems to timeout:

   × InfiniteQueryBehavior > InfiniteQueryBehavior should not enter an infinite loop when a page errors while retry is on #8046 5007ms
     → Test timed out in 5000ms.

I fixed it

@TkDodo TkDodo merged commit 068b764 into TanStack:main Apr 12, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
package: query-core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@manudeli @TkDodo