Reformat files with Ruff #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8 +/- ##
=======================================
Coverage 43.20% 43.20%
=======================================
Files 8 8
Lines 250 250
=======================================
Hits 108 108
Misses 142 142 ☔ View full report in Codecov by Sentry. |
jspaezp
reviewed
Jul 2, 2024
| - id: ruff | ||
| args: ['--fix'] | ||
| types_or: [ python, pyi, jupyter ] | ||
| args: [ --fix, --show-fixes ] |
There was a problem hiding this comment.
nice I didn't know --show-fixes was a thing
| @@ -8,7 +8,8 @@ | |||
| def read(mzml_file: str) -> dict[tuple[np.ndarray, np.ndarray]]: | |||
| """Parse the mzML file | |||
|
|
|||
| This parser is much faster than Pyteomics, but doesn't do any error checking. | |||
| This parser is much faster than Pyteomics, but doesn't do any error | |||
| checking. | |||
There was a problem hiding this comment.
Request: Can you also add a mention that it handles less types of mzml's ... it assumes gzip compressed arrays every time and assumes its all 64 bit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should follow #7. It simply runs
ruff formaton all the files.I'll rebase it to main after #7 is merged.