-
-
Notifications
You must be signed in to change notification settings - Fork 7
Add TaloMultiplayerPeer
and multiplayer sample.
#85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Add TaloMultiplayerPeer
and multiplayer sample.
#85
Conversation
b2714c9
to
d409c5b
Compare
TaloMultiplayerPeer
.TaloMultiplayerPeer
and multiplayer sample.
I'll try to look at this tomorrow or over the weekend :) |
da7c05c
to
38f4ea6
Compare
@Daylily-Zeleen looks like you're encountering rate limit errors. each socket connection is granted 100 requests per second. to get this sample working you would need to check if rate limit errors are received ( |
I'm not sure, I have test about this, connectd Your can adjust the |
You're right about the v1.error message not coming through - I need to investigate why this is. However, running this locally I can see in my docker logs that the clients are being disconnected because of the rate-limiting. I haven't worked with Godot multiplayer before so unfortunately I don't know where to adjust these settings, can you point me in the right direction? |
In my environment, set intervals to 0.02s (50 times per second) will broken the connection, too. 2025-03-03.14-30-03.mp4 |
That was it - setting both values to 0.2 fixes it for me. These should be the default values ideally. If you try setting it to a higher value does that work? Looks like there's a few things that need to happen before the can be merged:
I still haven't had a chance to look at the full code but the sample is looking really good! |
I adjust intervals to 0.03 second, the connection will become broken, too. |
Yeah you're right - I think I can increase the rate limit so that it handles synchronisation more smoothly |
I've bumped the rate limit now, hopefully it should work better for you? |
I think my network environment can't use Talo. The latency is over 1 second and can be disconnected easily. Maybe we need a new way to transfer message without rate limitation to implement |
By "disconnected" do you mean the clients are getting out of sync quickly? I don't think your latency would be affecting how quickly you're being rate limited given that the request count that contributes to the limit are reset every 1 second. I think you need some interpolation to handle the movement syncing, this is a pretty common pattern in games. With that in place you can increase the intervals. |
@Daylily-Zeleen in the latest dev branch, there's now a |
38f4ea6
to
a6afe17
Compare
a6afe17
to
65e0b8c
Compare
I collect messages into a queue and send them in I think my network environment can't use Talo, it seems like the sending rate of messages is unstable, see these videos. I will stop use Talo, but the |
Thanks @Daylily-Zeleen. I'm still not totally convinced it's anything to do with your network environment. I really appreciate all your contributions and I'll look into picking this up at some point :) |
Implemented through Talo Channels.
Need #72 .
Need test.
Run two instances of
sample/multiplayer/multiplayer.tscn
and connect them. Then continuously moving one of them, the synchronization will be broken after few seconds and push error:@tudddorrr could you test this pr to find the reason about this error?