Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selma styling updates #159

Merged
merged 1 commit into from
Jan 27, 2025
Merged

Conversation

t0mbrn
Copy link
Contributor

@t0mbrn t0mbrn commented Jan 20, 2025

  • Show own grades

  • Added loading animation for grade chart

  • Table header bug fixes

Continuation of #153

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
* Show own grades

* Added loading animation for grade chart

* Table header bug fixes
@t0mbrn t0mbrn requested a review from a team as a code owner January 20, 2025 16:51
@t0mbrn t0mbrn requested a review from cornzz January 20, 2025 16:51
@OliEfr
Copy link
Member

OliEfr commented Jan 20, 2025

If I followed correctly, the new changes regard the disable button. Did you look at @A-K-O-R-A's changes?
Then I will go ahead and merge.

@t0mbrn
Copy link
Contributor Author

t0mbrn commented Jan 20, 2025

If I followed correctly, the new changes regard the disable button. Did you look at @A-K-O-R-A's changes? Then I will go ahead and merge.

I did what @A-K-O-R-A wrote here.
I didnt have time to test them myself yet, will do so tomorrow/soon

@OliEfr
Copy link
Member

OliEfr commented Jan 26, 2025

Ok let me know briefly when you checked that the disable button works and I will merge

@t0mbrn
Copy link
Contributor Author

t0mbrn commented Jan 26, 2025

Ok let me know briefly when you checked that the disable button works and I will merge

hi, the disable button works now. The "gradePassed" is grey now instead of green but I dont care too much about that.
Regarding functional requirements everything works now -

LGTM

@OliEfr OliEfr merged commit b4a2747 into TUfast-TUD:main Jan 27, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants