Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: mypage api 연동 (badge history, level) #98

Merged
merged 10 commits into from
Sep 30, 2024
Merged

feat: mypage api 연동 (badge history, level) #98

merged 10 commits into from
Sep 30, 2024

Conversation

d0422
Copy link
Contributor

@d0422 d0422 commented Sep 30, 2024

  • badge history 연동
  • level 연동
  • 경상, 전라, 충청이 두번 표기되는 오류 해결
  • 여행 추가시 navigation 오류 해결

@d0422 d0422 self-assigned this Sep 30, 2024
@d0422 d0422 requested a review from HBSPS September 30, 2024 06:40
Copy link
Contributor

@HBSPS HBSPS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다!

Comment on lines 25 to 57
const renderContent = () => {
if (isLoading) {
return (
<View>
<Font type="body1" color="black">
잠시만
</Font>
<Font type="body1" color="black">
기다려주세요
</Font>
</View>
);
}

return (
selectedBadge &&
badgeHistory?.map((badgeInfo, index) => (
<BadgeListItem
key={`data-${index}`}
location={selectedBadge}
title={
getDisplayRegion({
locationEnum: badgeInfo.region,
cityEnum: badgeInfo.city,
onlyCity: true,
}) || ''
}
date={badgeInfo.createdAt}
content={ACQUISITION_MAPPER[badgeInfo.acquisitionType]}
/>
))
);
};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이 부분은 컴포넌트로 만들 수 없나요?? 추가로 Suspense 적용은 어려울까요??

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

반영하였습니다! 96352b6

@d0422 d0422 merged commit fcf053c into main Sep 30, 2024
1 check passed
@d0422 d0422 deleted the feat/mypage-api branch September 30, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants