Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remember last used workflow per backend #24

Merged
merged 5 commits into from
Dec 17, 2024

Conversation

mschuettlerTNG
Copy link
Collaborator

Description:

Please provide a brief description of the changes made in this pull request.

Related Issue:

If this pull request is related to any existing issue, please mention the issue number here.

Changes Made:

Please list down the specific changes made in this pull request.

Testing Done:

Please describe the testing that has been done to ensure the changes made in this pull request are functioning as expected.

Screenshots:

If applicable, please provide screenshots or GIFs or videos to visually demonstrate the changes made.

Checklist:

  • I have tested the changes locally.
  • I have self-reviewed the code changes.
  • I have updated the documentation, if necessary.

Copy link

@marijnvg-tng marijnvg-tng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't this clash with the lastUsedBackend variable from PR#22 in globalSetup ? It seems like it tries to do a similar thing but without reactivity (?)

@mschuettlerTNG mschuettlerTNG force-pushed the remember-last-used-workflow-per-backend branch from ac138f2 to 36ee53d Compare December 17, 2024 10:55
@florianesser-tng florianesser-tng force-pushed the dev branch 2 times, most recently from e3b988d to d3eb229 Compare December 17, 2024 16:07
@florianesser-tng florianesser-tng merged commit 507d87f into dev Dec 17, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants