Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure sample format code value gets extracted from Numpy struct #286

Merged
merged 1 commit into from
Apr 4, 2025

Conversation

tasansal
Copy link
Contributor

@tasansal tasansal commented Apr 4, 2025

Python 3.13.0 has a bug where it can't compare singleton numpy arrays in Enum construction. It was fixed in 3.13.1; however, we should still support 3.13.0.

In this fix we ensure the singleton item is extracted with .item() method, consistent with other value extractions in the same function.

This was noticed due to documentation build errors on readthedocs with 3.13.0.

@tasansal tasansal self-assigned this Apr 4, 2025
@tasansal tasansal added the bug Something isn't working label Apr 4, 2025
Copy link

codecov bot commented Apr 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.66%. Comparing base (511b652) to head (962f86f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #286   +/-   ##
=======================================
  Coverage   95.66%   95.66%           
=======================================
  Files          49       49           
  Lines        2397     2397           
  Branches      128      128           
=======================================
  Hits         2293     2293           
  Misses         80       80           
  Partials       24       24           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tasansal tasansal merged commit 135f2dd into main Apr 4, 2025
32 checks passed
@tasansal tasansal deleted the fix-py313-enum-bug branch April 4, 2025 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant