Changed gloss and desc for msName #2645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also added German translation
sydb
approved these changes
Dec 23, 2024
There was a problem hiding this comment.
Overall looks great. I would prefer “as opposed to a” instead of “instead of any” in
… other object, instead of any formal identification number …
(Approving, because even without this suggested tweak, this is an improvement. But of course, I did not actually read the German. : - )
according to SB's suggestion
|
Updated description in |
sydb
requested review from
peterstadler and
martinascholger
and removed request for
HelenaSabel and
trishaoconnor
peterstadler
requested changes
Jan 6, 2025
martinascholger
requested changes
Jan 13, 2025
Co-authored-by: Peter Stadler <stadlerpeter@yahoo.fr>
|
I've just applied the "Signatur" suggestion that @martinascholger and @peterstadler agreed upon. |
|
Approving this PR because we've refined the prose edits. We can open a new ticket to update the gloss in other languages. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
according to suggestions by @jamescummings and @sydb.
I also added German translation.
closes #2434
Perhaps someone might update the Spanish, Italian etc.?