Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update copyright notice #2526

Merged
merged 6 commits into from
Feb 26, 2024
Merged

update copyright notice #2526

merged 6 commits into from
Feb 26, 2024

Conversation

sydb
Copy link
Member

@sydb sydb commented Feb 9, 2024

Per #2514, updated the copyright notice to a shorter comment that fits on 1 line in the Source/Specs/*.xml, Source/Guidelines/en/*.xml, and Source/Guidelines/fr/HD-Header.xml files.

For a detailed discussion of what I did, see post on the issue itself.

Updated the copyright notice to a shorter comment that fits on 1 line in the Source/Specs/*.xml, Source/Guidelines/en/*.xml, and Source/Guidelines/fr/HD-Header.xml files.
@sydb sydb added this to the Guidelines 4.8.0 milestone Feb 9, 2024
Copy link
Member

@ebeshero ebeshero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for removing the extra line breaks and notation, short of reducing the slightly repetitive wording itself.

Copy link
Contributor

@trishaoconnor trishaoconnor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me. The updated copyright is more concise and it looks tidier having the notice on one line.

@sydb
Copy link
Member Author

sydb commented Feb 9, 2024

@ebeshero — Feel free to change to or suggest different wording. Now that it is a completely consistent string all on one line, it is trivial to change. (I would use Perl, but sed, awk, or any good text editor like oXygen, BBEdit, Emacs, vim, or Sublime, could do this easily.)

@ebeshero
Copy link
Member

I double-checked the British English spelling of verb (license) and noun (licence), and it's all fine. Glad you put back the XML declaration (and found more such to missing lines to address).

@ebeshero ebeshero merged commit ab6fdf0 into dev Feb 26, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants